Add support for registering attributes with rustc in plugins #25168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets plugin authors opt attributes out of the `custom_attribute` and `unused_attribute` checks.
|
I added a test r? @huonw |
|
|
||
| /// Register an attribute with an attribute type | ||
| /// | ||
| /// Registered attributes will bypass the `custom_attribute` feature gate |
There was a problem hiding this comment.
This and the next two lines can be one paragraph. Also, all these sentences need .s.
|
(addressed) |
| @@ -130,4 +135,19 @@ impl<'a> Registry<'a> { | |||
| pub fn register_llvm_pass(&mut self, name: &str) { | |||
| self.llvm_passes.push(name.to_owned()); | |||
| } | |||
|
|
|||
|
|
|||
| /// Register an attribute with an attribute type | |||
|
(addressed) |
Manishearth
force-pushed
the
register_attr
branch
from
b1fe327 to
10e57cb
Compare
Manishearth
force-pushed
the
register_attr
branch
from
10e57cb to
22b720a
Compare
|
@bors r+ |
|
📌 Commit 22b720a has been approved by |
bors
added a commit
that referenced
this pull request
May 24, 2015
This lets plugin authors opt attributes out of the `custom_attribute` and `unused_attribute` checks. cc @thepowersgang
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
May 24, 2015
This lets plugin authors opt attributes out of the `custom_attribute` and `unused_attribute` checks. cc @thepowersgang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets plugin authors opt attributes out of the
custom_attributeand
unused_attributechecks.cc @thepowersgang