Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc fixes for associated items #25225

Merged
merged 2 commits into from
May 11, 2015
Merged

Conversation

bluss
Copy link
Member

@bluss bluss commented May 8, 2015

Rustdoc fixes for associated items

This is related to isssue #22442 and solves it partly.

This solves the search index links of associated types and constants,
so that they link to the trait page.

Also add an Associated Constants section if constants are present.

This is related to isssue rust-lang#22442 and solves it partly.

This solves the links of associated types and constants, so that they
link to the trait page.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

Can you add a test for the emission of the associated constants section? Regardless, though, thanks!

@bluss
Copy link
Member Author

bluss commented May 9, 2015

Do you know how I can run the src/test/rustdoc tests? Without a full make check. For other categories I can make check-rpass and so on.

Section only visible if there are assoc. consts. present.
@bluss
Copy link
Member Author

bluss commented May 9, 2015

I found make check-stage2-rustdocck

Updated the tests -- is that sufficient, it just checks for something with the right id= tag?

@alexcrichton
Copy link
Member

Yeah that looks good to me, thanks!

@bors: r+ c46f3ff

@alexcrichton alexcrichton assigned alexcrichton and unassigned huonw May 11, 2015
bors added a commit that referenced this pull request May 11, 2015
Rustdoc fixes for associated items

This is related to isssue #22442 and solves it partly.

This solves the search index links of associated types and constants,
so that they link to the trait page.

Also add an Associated Constants section if constants are present.
@bors
Copy link
Contributor

bors commented May 11, 2015

⌛ Testing commit c46f3ff with merge 4b88e8f...

@bors bors merged commit c46f3ff into rust-lang:master May 11, 2015
@bluss bluss deleted the doc-search-assoc-items branch May 11, 2015 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants