Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few diagnostic messages #25255

Merged
merged 2 commits into from
May 10, 2015
Merged

Add a few diagnostic messages #25255

merged 2 commits into from
May 10, 2015

Conversation

caipre
Copy link
Contributor

@caipre caipre commented May 10, 2015

Add a few diagnostic messages; part of #24407.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

@bors: r+ 41f2e5c rollup

Thanks!

bors added a commit that referenced this pull request May 10, 2015
@bors
Copy link
Collaborator

bors commented May 10, 2015

🔒 Merge conflict

@bors
Copy link
Collaborator

bors commented May 10, 2015

☔ The latest upstream changes (presumably #25262) made this pull request unmergeable. Please resolve the merge conflicts.

@caipre
Copy link
Contributor Author

caipre commented May 10, 2015

rebased

@alexcrichton
Copy link
Member

@bors: r+ ffc0d04

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 10, 2015
bors added a commit that referenced this pull request May 10, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 10, 2015
bors added a commit that referenced this pull request May 10, 2015
@bors bors merged commit ffc0d04 into rust-lang:master May 10, 2015
@caipre caipre deleted the diagnostic-messages branch July 11, 2015 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants