Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second doc backport #25273

Merged
merged 13 commits into from
May 10, 2015
Merged

Second doc backport #25273

merged 13 commits into from
May 10, 2015

Conversation

steveklabnik
Copy link
Member

Nick Hamann and others added 13 commits May 10, 2015 14:24
@steveklabnik
Add two examples for Path::new
9577561
@steveklabnik
Address some nits
68f8c54
@steveklabnik
Separate code into two code blocks
4ee11f4
@mbrubeck @steveklabnik
Explain how to create a Stdin or Stdout
41bcb82
@frewsxcv @steveklabnik
Utilize while let instead of loop with break in doc-comment
db1dc5d
@steveklabnik
collections: Improve example for as_string and as_vec
7c98626
@gareins @steveklabnik
IMO better borrow_mut() documentation on RefCell
814acb8 
Previous borrow() is enough to make borrow_mut() panic, no need to have borrow_mut() twice. [This](http://is.gd/woKKAW)
@frewsxcv @steveklabnik
Indicate function call is code-like in doc-comment
0deff27
@frewsxcv @steveklabnik
Make From::from example more idiomatic / simpler
df42cbd
@steveklabnik
Improve libstd/net/udp.rs documentation.
97e0803 
This adds some missing punctuation, adds a missing word, and
corrects a bug in the description of `send_to`, which actually
returns the number of bytes written on success.

Fixes rust-lang#24925.
@steveklabnik
Add some missing punctuation in the libstd/net/ip.rs docs.
7b1ff61
@steveklabnik
Add some missing punctuation in the libstd/net/tcp.rs docs.
f850f59
@steveklabnik
Improve libstd/net/addr.rs documentation.
957e42a 
This adds some missing punctuation and converts uses of "Gets" to
"Returns". This sounds better to my ear, but more importantly is
more consistent with the documentation from other files.
@rust-highfive
Copy link
Collaborator

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik added a commit that referenced this pull request May 10, 2015
@steveklabnik
Merge pull request #25273 from steveklabnik/second_doc_backport
750da68 
Second doc backport
@steveklabnik steveklabnik merged commit 750da68 into rust-lang:beta May 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@steveklabnik @rust-highfive @pcwalton @mbrubeck @frewsxcv @gareins