TRPL: dining philosophers

[steveklabnik]

This is a little rough, and it needs squashed and section headers, but i'd like to get some eyes on it sooner rather than later.

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[steveklabnik]

oh, and i might not need the channel at the end: https://twitter.com/florob/status/597935275394912259

considering an extra 'cleanup' section

[kevinmehall]

"has is" -> "is"

[steveklabnik]

I believe all nits are addressed. r? @alexcrichton

[Florob]

So, maybe I'm just terribly dense, but I still don't see why you need the channel at all. AFAICT, it does not become obsolete by joining the threads, but is unnecessary from the get go.

[alexcrichton]

I'm still kinda worried about all these .ok().expect(...) calls throughout these examples, some of them I think may be giving the wrong impression. For example this doesn't really indicate anything about "couldn't finish eating" but rather that no one's listening for the notification that the eating is done. Down below there's:

.ok().expect("Couldn't aquire left mutex");

If Err is returned, though, the mutex was indeed acquired, it was just poisoned.

Would it be possible to just use unwrap everywhere? I would consider unwrap as the idiomatic way to indicate that an error should not ever be happening here, and errors should definitely not ever be happening in these examples.

[steveklabnik]

I guess I've seen people mostly argue that unwrap gives a poor error message, and ok/expect at least lets you customize it.

that said, I'm sympathetic to the last thing you've said, so yeah, let me re-work it.

[alexcrichton]

I do also agree with @Florob that the channel involvement here may not be pulling its weight by the time we get to the end.

[steveklabnik]

I added a thing at the end about removing the channel entirely.

[steveklabnik]

@Florob yeah, maybe that is true. sigh.

[steveklabnik]

Okay, I removed the channels entirely, and use unwrap.

[alexcrichton]

"and report back that they're done", perhaps drop this phrase?

[steveklabnik]

nice catch. editing your own prose is so hard :(

[alexcrichton]

This may need to be rephrased as it's not just a plain vector instead of an array.

[steveklabnik]

👍

[alexcrichton]

Looks good to me! A few last minor nits and otherwise r=me

Nice chapter @steveklabnik!

[steveklabnik]

@bors: r=alexcrichton rollup

[bors]

📌 Commit 2ba6169 has been approved by alexcrichton

[quantheory]

Blegh, I think this is already being tested in a rollup, but maybe there will be a quick chance to fix a couple things soon.

s/mult-threading/multi-threading/

Edit: Never mind, I was missing a paragraph. This is the only nit I found.

[steveklabnik]

I'll make a new PR for master, and work it into my backport. Thanks!