Skip to content

Conversation

@GSam
Copy link
Contributor

@GSam GSam commented May 12, 2015

As it is, save-analysis appears to return the span for the 'mut' in a declaration 'static mut identifier...' instead of the identifier. This minor change appears to fix the problem, by skipping the mut when it is present.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@nrc
Copy link
Member

nrc commented May 13, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 13, 2015

📌 Commit 46753da has been approved by nrc

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 13, 2015
As it is, save-analysis appears to return the span for the 'mut' in a declaration 'static mut identifier...' instead of the identifier. This minor change appears to fix the problem, by skipping the mut when it is present.
@steveklabnik
Copy link
Contributor

@bors: rollup-

@steveklabnik
Copy link
Contributor

sorry, kicking everything non-docs out of the rollup for now so i can go to sleep

@bors
Copy link
Collaborator

bors commented May 13, 2015

⌛ Testing commit 46753da with merge af41097...

bors added a commit that referenced this pull request May 13, 2015
As it is, save-analysis appears to return the span for the 'mut' in a declaration 'static mut identifier...' instead of the identifier. This minor change appears to fix the problem, by skipping the mut when it is present.
@bors
Copy link
Collaborator

bors commented May 13, 2015

@bors bors merged commit 46753da into rust-lang:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants