std: Handle DT_DIR file types in dirent pointers
#25632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This "fast path" in `DirEntry::file_type` on Unix wasn't turning out to be so much of a fast path as the `DT_DIR` case wasn't handled, so directories fell back to using `lstat` instead. This commit adds the missing case to return quickly if a path is a directory and `DirEntry::file_type` is used.
|
@bors r+ |
|
📌 Commit e7aad28 has been approved by |
|
⌛ Testing commit e7aad28 with merge 850b338... |
|
💔 Test failed - auto-linux-32-opt |
|
@bors retry |
|
⌛ Testing commit e7aad28 with merge 9ccba72... |
|
💔 Test failed - auto-linux-64-opt |
|
@bors retry |
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
This "fast path" in `DirEntry::file_type` on Unix wasn't turning out to be so much of a fast path as the `DT_DIR` case wasn't handled, so directories fell back to using `lstat` instead. This commit adds the missing case to return quickly if a path is a directory and `DirEntry::file_type` is used.
bors
added a commit
that referenced
this pull request
May 23, 2015
This "fast path" in `DirEntry::file_type` on Unix wasn't turning out to be so much of a fast path as the `DT_DIR` case wasn't handled, so directories fell back to using `lstat` instead. This commit adds the missing case to return quickly if a path is a directory and `DirEntry::file_type` is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "fast path" in
DirEntry::file_typeon Unix wasn't turning out to be somuch of a fast path as the
DT_DIRcase wasn't handled, so directories fellback to using
lstatinstead. This commit adds the missing case to returnquickly if a path is a directory and
DirEntry::file_typeis used.