Rollup of 7 pull requests #25711
Closed
Rollup of 7 pull requests #25711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, when checking for common gendered words elsewhere, I found one 'he', moved to 'they' as well. rust-lang#25640 (comment)
…r=aturon The `debug_builders` feature is up for 1.1 stabilization in rust-lang#24028. This commit stabilizes the API as-is with no changes. Some nits that @alexcrichton mentioned that may be worth discussing now if anyone cares: * Should `debug_tuple_struct` and `DebugTupleStruct` be used instead of `debug_tuple` and `DebugTuple`? It's more typing but is a technically more correct name. * `DebugStruct` and `DebugTuple` have `field` methods while `DebugSet`, `DebugMap` and `DebugList` have `entry` methods. Should we switch those to something else for consistency? cc @alexcrichton @aturon
Also, when checking for common gendered words elsewhere, I found one 'he', moved to 'they' as well. rust-lang#25640 (comment)
Cleanup extracted from rust-lang#25684. r? @alexcrichton
Reduces pre-trans heap baseline (tested on `fn main() {}`) from 1.2MB to 696kB.
Most of the remaining allocations are used by imported macros.
While it might be possible to also load macros lazily, doing so is non-trivial and this PR doesn't tackle that.
Sounds better to me this way. r @steveklabnik ?
|
@bors: r+ p=10 |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit d9cbea0 has been approved by |
|
⌛ Testing commit d9cbea0 with merge 10d6ae4... |
|
💔 Test failed - auto-win-gnu-64-nopt-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core::numusingSelf#25687, Lazy-load filemaps from external crates. #25703, better describe the stdlib #25709