-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add community translations. #25751
Add community translations. #25751
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Wow, supercool! Thanks. By the way, would be possible to announce #rust-ru channel somewhere? |
@mkpankov yeah, having it here would be good. It's on mozilla's IRC? |
@steveklabnik Yes. This channel on Mozilla's IRC. |
@steveklabnik Ok, just to confirm: the channel is at Mozilla's server here |
I realized there are actually several language-specific channels, so we should add them in a new section, but I'll do that in a different PR r? @brson |
I think there should be an added disclaimer that these are not maintained by Rust developers, and that they may be out of date. |
@sinistersnare Does "Community" not communicate that effectively enough? |
@steveklabnik, no, I do not think that it is enough. |
@goyox86 https://github.com/rust-lang/rust/tree/master/src/doc/trpl is all you need, just make them Spanish:) |
r=me but seems like some comments may not be completely addressed yet |
My thoughts is that by putting a huge disclaimer, we risk minimizing the hard work everyone is doing to translate the book. I think just saying "community" is enough to communicate the situation without being overly negative. |
I am also going to add the non-english channels to the IRC list, but I need to figure out how to query for all rust related channels on moznet, and that's fine as a separate PR |
@bors: r=brson rollup |
📌 Commit b78c8f1 has been approved by |
Hey guys Spanish translation started here :) |
b78c8f1
to
73c7d61
Compare
@bors: r=brson rollup |
📌 Commit 73c7d61 has been approved by |
@goyox86 thanks, snuck it in :) |
@steveklabnik Correction: this is the github repo of the book: https://github.com/goyox86/elpr 😄 |
73c7d61
to
321c2f4
Compare
@bors: r=brson rollup |
📌 Commit 321c2f4 has been approved by |
Oh, I feel stupid for not bringing these issues up earlier. Still, is this file reflected on the web somewhere? I feel it might be hard to actually discover these links. Also, isn't it better to insert them directly to TRPL introduction for example, as AFAIK all of these translations are translations of just TRPL, not the entirety of the documentation. |
@mkpankov it will be on http://doc.rust-lang.org/ tomorrow |
/cc @kgv, @rust-kr, @KaiserY, @mkpankov