Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community translations. #25751

Merged
merged 1 commit into from
Jun 2, 2015
Merged

Conversation

steveklabnik
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@mkpankov
Copy link
Contributor

Wow, supercool! Thanks.

By the way, would be possible to announce #rust-ru channel somewhere?

@steveklabnik
Copy link
Member Author

@mkpankov yeah, having it here would be good. It's on mozilla's IRC?

@ithamsteri
Copy link

@steveklabnik Yes. This channel on Mozilla's IRC.

@mkpankov
Copy link
Contributor

@steveklabnik Ok, just to confirm: the channel is at Mozilla's server here

@steveklabnik
Copy link
Member Author

I realized there are actually several language-specific channels, so we should add them in a new section, but I'll do that in a different PR

r? @brson

@sinistersnare
Copy link
Contributor

I think there should be an added disclaimer that these are not maintained by Rust developers, and that they may be out of date.

@steveklabnik
Copy link
Member Author

@sinistersnare Does "Community" not communicate that effectively enough?

@goyox86
Copy link
Contributor

goyox86 commented May 27, 2015

Hi guys @kgv, @rust-kr, @KaiserY, @mkpankov I want to start translating to Spanish do you have any advice on the process to setup the env for translating?

@sinistersnare
Copy link
Contributor

@steveklabnik, no, I do not think that it is enough.

@KaiserY
Copy link

KaiserY commented May 28, 2015

@goyox86 https://github.com/rust-lang/rust/tree/master/src/doc/trpl is all you need, just make them Spanish:)

@brson
Copy link
Contributor

brson commented Jun 1, 2015

r=me but seems like some comments may not be completely addressed yet

@steveklabnik
Copy link
Member Author

My thoughts is that by putting a huge disclaimer, we risk minimizing the hard work everyone is doing to translate the book. I think just saying "community" is enough to communicate the situation without being overly negative.

@steveklabnik
Copy link
Member Author

I am also going to add the non-english channels to the IRC list, but I need to figure out how to query for all rust related channels on moznet, and that's fine as a separate PR

@steveklabnik
Copy link
Member Author

@bors: r=brson rollup

@bors
Copy link
Contributor

bors commented Jun 1, 2015

📌 Commit b78c8f1 has been approved by brson

@goyox86
Copy link
Contributor

goyox86 commented Jun 1, 2015

Hey guys Spanish translation started here :)

http://goyox86.gitbooks.io/el-libro-de-rust/content/ 😄

@steveklabnik
Copy link
Member Author

@bors: r=brson rollup

@bors
Copy link
Contributor

bors commented Jun 1, 2015

📌 Commit 73c7d61 has been approved by brson

@steveklabnik
Copy link
Member Author

@goyox86 thanks, snuck it in :)

@goyox86
Copy link
Contributor

goyox86 commented Jun 1, 2015

@steveklabnik Correction: this is the github repo of the book: https://github.com/goyox86/elpr 😄

@steveklabnik
Copy link
Member Author

@bors: r=brson rollup

@bors
Copy link
Contributor

bors commented Jun 1, 2015

📌 Commit 321c2f4 has been approved by brson

bors added a commit that referenced this pull request Jun 2, 2015
@mkpankov
Copy link
Contributor

mkpankov commented Jun 2, 2015

Oh, I feel stupid for not bringing these issues up earlier.

Still, is this file reflected on the web somewhere? I feel it might be hard to actually discover these links.

Also, isn't it better to insert them directly to TRPL introduction for example, as AFAIK all of these translations are translations of just TRPL, not the entirety of the documentation.

@bors bors merged commit 321c2f4 into rust-lang:master Jun 2, 2015
@steveklabnik
Copy link
Member Author

@mkpankov it will be on http://doc.rust-lang.org/ tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants