Skip to content

Fix auto_ref for fat pointers #25773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2015
Merged

Fix auto_ref for fat pointers #25773

merged 1 commit into from
May 25, 2015

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented May 25, 2015

Fat pointers aren't immediate, so in a datum, they're not actually
ByValue but ByRef.

Fixes #24589

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@dotdash
Copy link
Contributor Author

dotdash commented May 25, 2015

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned alexcrichton May 25, 2015
Fat pointers aren't immediate, so in a datum, they're not actually
ByValue but ByRef.

Fixes rust-lang#24589
@eddyb
Copy link
Member

eddyb commented May 25, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented May 25, 2015

📌 Commit efd3e75 has been approved by eddyb

bors added a commit that referenced this pull request May 25, 2015
Fat pointers aren't immediate, so in a datum, they're not actually
ByValue but ByRef.

Fixes #24589
@bors
Copy link
Collaborator

bors commented May 25, 2015

⌛ Testing commit efd3e75 with merge 45001c0...

@bors bors merged commit efd3e75 into rust-lang:master May 25, 2015
@dotdash dotdash deleted the deref_dst branch July 27, 2015 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM abort: Ptr must be a pointer to Val type!
5 participants