Associate each path in a use declaration with the item in the AST map
#25791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
Currently, for `use` declarations with multiple paths, only the `use` item itself is saved in the AST map, not the individual path nodes. This can lead to a problem when a span of a specific path node is needed. For example, rust-lang#24818 caused an ICE because of this, in `ImportResolver::check_for_conflicting_import()`. Fixes rust-lang#25763.
barosl
force-pushed
the
use-paths-as-items
branch
from
7196979 to
0ae30e6
Compare
Member
Collaborator
bors
added a commit
that referenced
this pull request
May 27, 2015
Currently, for `use` declarations with multiple paths, only the `use` item itself is saved in the AST map, not the individual path nodes. This can lead to a problem when a span of a specific path node is needed. For example, #24818 caused an ICE because of this, in `ImportResolver::check_for_conflicting_import()`. Fixes #25763.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for
usedeclarations with multiple paths, only theuseitem itself is saved in the AST map, not the individual path nodes. This can lead to a problem when a span of a specific path node is needed.For example, #24818 caused an ICE because of this, in
ImportResolver::check_for_conflicting_import().Fixes #25763.