Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant compiler check. Allow CC override #25792

Merged
merged 1 commit into from
May 27, 2015
Merged

Remove redundant compiler check. Allow CC override #25792

merged 1 commit into from
May 27, 2015

Commits on May 26, 2015

  1. Remove redundant compiler check. Allow CC override

    Currently, there are two conditional blocks that exist to check for "clang or gcc"
    
    On line 866:
    
    ```
    if [ -z "$CFG_ENABLE_CLANG" -a -z "$CFG_GCC" ]
    then
        err "either clang or gcc is required"
    fi
    ```
    and on line 1019:
    
    ```
    if [ -z "$CC" -a -z "$CFG_ENABLE_CLANG" -a -z "$CFG_GCC" ]
    then
        err "either clang or gcc is required"
    fi
    ```
    
    Given the order of the clauses, this results in the "either clang or gcc is required" error from the earlier block, (even) when CC is set. 
    
    The expected behaviour is to honour user-flags, in this case CC.
    
    Aside from removing all hand-holdy compiler checks in favour of actual compiler *feature* checks, this change removes the redundant former block in favour of the latter block, which appears designed to allow the expected behaviour.
    koobs committed May 26, 2015
    Configuration menu
    Copy the full SHA
    d323c14 View commit details
    Browse the repository at this point in the history