Prevent comparison and dereferencing of raw pointers in constexprs #25840
+61
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @nrc Prohibiting equality (which is needed for #25768) hurts inference too much - it can wait for rust-lang/rfcs#1135. |
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
There was a problem hiding this comment.
Could you add a comment saying what is being tested
|
r=me with the comment added |
arielb1
force-pushed
the
ptr-compare-fixes
branch
4 times, most recently
from
9fe22e6
to
7d69a71
Compare
|
@bors r+ |
|
📌 Commit 7d69a71 has been approved by |
arielb1
force-pushed
the
ptr-compare-fixes
branch
from
7d69a71
to
080311d
Compare
|
@bors r+ |
|
📌 Commit 080311d has been approved by |
bors
added a commit
that referenced
this pull request
May 28, 2015
|
⌛ Testing commit 080311d with merge 6a3d55a... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25826.