Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Stabilize a number of new fs features #25844

Merged
merged 1 commit into from
Jun 12, 2015

Commits on Jun 10, 2015

  1. std: Stabilize a number of new fs features

    This commit stabilizes the following APIs, slating them all to be cherry-picked
    into the 1.1 release.
    
    * fs::FileType (and transitively the derived trait implementations)
    * fs::Metadata::file_type
    * fs::FileType::is_dir
    * fs::FileType::is_file
    * fs::FileType::is_symlink
    * fs::DirEntry::metadata
    * fs::DirEntry::file_type
    * fs::DirEntry::file_name
    * fs::set_permissions
    * fs::symlink_metadata
    * os::raw::{self, *}
    * os::{android, bitrig, linux, ...}::raw::{self, *}
    * os::{android, bitrig, linux, ...}::fs::MetadataExt
    * os::{android, bitrig, linux, ...}::fs::MetadataExt::as_raw_stat
    * os::unix::fs::PermissionsExt
    * os::unix::fs::PermissionsExt::mode
    * os::unix::fs::PermissionsExt::set_mode
    * os::unix::fs::PermissionsExt::from_mode
    * os::unix::fs::OpenOptionsExt
    * os::unix::fs::OpenOptionsExt::mode
    * os::unix::fs::DirEntryExt
    * os::unix::fs::DirEntryExt::ino
    * os::windows::fs::MetadataExt
    * os::windows::fs::MetadataExt::file_attributes
    * os::windows::fs::MetadataExt::creation_time
    * os::windows::fs::MetadataExt::last_access_time
    * os::windows::fs::MetadataExt::last_write_time
    * os::windows::fs::MetadataExt::file_size
    
    The `os::unix::fs::Metadata` structure was also removed entirely, moving all of
    its associated methods into the `os::unix::fs::MetadataExt` trait instead. The
    methods are all marked as `#[stable]` still.
    
    As some minor cleanup, some deprecated and unstable fs apis were also removed:
    
    * File::path
    * Metadata::accessed
    * Metadata::modified
    
    Features that were explicitly left unstable include:
    
    * fs::WalkDir - the semantics of this were not considered in the recent fs
      expansion RFC.
    * fs::DirBuilder - it's still not 100% clear if the naming is right here and if
      the set of functionality exposed is appropriate.
    * fs::canonicalize - the implementation on Windows here is specifically in
      question as it always returns a verbatim path. Additionally the Unix
      implementation is susceptible to buffer overflows on long paths unfortunately.
    * fs::PathExt - as this is just a convenience trait, it is not stabilized at
      this time.
    * fs::set_file_times - this funciton is still waiting on a time abstraction.
    alexcrichton committed Jun 10, 2015
    Configuration menu
    Copy the full SHA
    ec68c4a View commit details
    Browse the repository at this point in the history