Rollup of 11 pull requests #25870
Closed
Rollup of 11 pull requests #25870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
May 29, 2015
steveklabnik
commented
- Successful merges: Document #[repr] on non-C-like enums #25651, Use an iterator for reader::tagged_docs. #25760, Add a missing space to the Glossary page of TRPL #25788, Improve Debug documentation #25830, Contributing guide should explain the issue tracker tags #25832, Improve docs for Vec::as_slice and as_mut_slice #25838, reference: floating-point types are machine types, not machine-dependent types #25854, TRPL: Fix Unescaped URL #25857, removed lonely closing parenthesis #25864, Corrected typo #25865, Update style guide with latest commits from rust-guidelines #25866
- Failed merges:
rustc accepts the following today:
#[repr(u8)]
enum Flag<T> {
Dropped,
Alive(T),
}
and it has a good use (it appears to me): this inhibits the non-nullable
pointer optimization that the regular Option<T> and similar enums allow.
Document this in the reference, and add tests to make sure it compiles.
This means that we guarantee with `repr` that the discriminant will be
present and with that size, but not sure if we want to guarantee
anything more (no guarantee on placement in struct).
There was no opening parenthesis for this closing parenthesis...
"workd" corrected to "world"
A discussion at rust-lang#25832 established what the abbreviations mean.
The current version of hoedown treats lists interrupting paragraphs in the Markdown.pl style rather than CommonMark, so a newline is needed for the list to be rendered properly.
"Idiomatic code should not use extra whitespace in the middle of a line to provide alignment."
Document #[repr] on non-C-like enums
rustc accepts the following today:
#[repr(u8)]
enum Flag<T> {
Dropped,
Alive(T),
}
and it has a good use (it appears to me): this inhibits the non-nullable
pointer optimization that the regular Option<T> and similar enums allow.
Document this in the reference, and add tests to make sure it compiles.
This means that we guarantee with `repr` that the discriminant will be
present and with that size, but not sure if we want to guarantee
anything more (no guarantee on placement in struct).
…ossary, r=steveklabnik r? @steveklabnik
…lexcrichton I took a guess at what they mean, but could be totally wrong. Please comment, and I'll update the PR with corrections!
Thanks to @cers who reported this in killercup/trpl-ebook#14! r? @steveklabnik
There was no opening parenthesis for this closing parenthesis...
"workd" corrected to "world"
…abnik So that rust-guidelines can be deleted and src/doc/style can prosper as the official home of the rust guidelines. 😃
|
@bors: r+ p=1 |
|
📌 Commit a9d9ff6 has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit a9d9ff6 with merge ed3697c... |
|
💔 Test failed - auto-linux-64-nopt-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.