Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bash in configure #25889

Closed
wants to merge 1 commit into from
Closed

Conversation

steveklabnik
Copy link
Member

Many *NIXes alias /bin/sh to bash, but not all do, and this is
a bash script, not an sh script.

r? @brson

@tshepang
Copy link
Member

Does the script fail with dash?

@sfackler
Copy link
Member

It fails with Solaris's sh, at the very least: #25845

@globin
Copy link
Contributor

globin commented May 30, 2015

Please use /usr/bin/env bash. The path to bash is not necessarily deterministic.

@sfackler
Copy link
Member

Is the path to env more deterministic than the path to bash?

@globin
Copy link
Contributor

globin commented May 31, 2015

http://en.wikipedia.org/wiki/Shebang_%28Unix%29#Portability

I am mostly using NixOS which only has /bin/sh and /usr/bin/env in the normal locations and everything else gets added to my PATH dynamically depending on my current environment I'm using. Because of that I can have multiple versions of software/libraries installed without them interfering.
E.g. that means no need for multirust.

Many *NIXes alias /bin/sh to bash, but not all do, and this is
a bash script, not an sh script.
@steveklabnik
Copy link
Member Author

Good call @globin

@brson
Copy link
Contributor

brson commented Jun 1, 2015

This has always been intended to be a sh script, not a bash script, as are all of our shell scripts. There are unix environments without bash - consider busybox. I have actually put a great deal of effort to avoid bashisms, and I'm not yet feeling the motivation to abandon that. So I'm not convinced.

@brson
Copy link
Contributor

brson commented Jun 3, 2015

I want to keep aiming for sh compatibility for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants