doc: improve some of str examples #25912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -1195,6 +1177,7 @@ impl str { | |||
| /// | |||
| /// ``` | |||
| /// assert_eq!("11foo1bar11".trim_matches('1'), "foo1bar"); | |||
| /// assert_eq!("123foo1bar123".trim_matches(|c: char| c.is_numeric()), "foo1bar"); | |||
There was a problem hiding this comment.
this could be char::is_numeric too?, just like the split example?
|
I like the new formulations, it should be friendlier to read. r=me with the nit fixed for consistency |
| @@ -1494,7 +1472,7 @@ impl str { | |||
| /// ``` | |||
| /// let s = "Löwe 老虎 Léopard"; | |||
| /// | |||
| /// assert_eq!(s.find(|c: char| c.is_whitespace()), Some(5)); | |||
| /// assert_eq!(s.find(cahr::is_whitespace), Some(5)); | |||
There was a problem hiding this comment.
Sorry, it's fixed now. I meant only to ping you once the tests passed.
You may have noticed that this is one example of removing some more needless usage of closures.
|
Thank you! |
|
@bors: r+ |
|
📌 Commit 0335a94 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.