-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Extend dead code lint to detect more unused enum variants, rebased #25961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
Could you add a test like: enum Foo { A, B }
fn bar() -> Foo {
match Foo::A {
Foo::A | Foo::B => Foo::B
}
} That is, ensuring that alternation doesn't get cause variants to count as unused. |
r? @huonw |
Added a test. |
Ping? |
Another ping. |
@bors r+ sorry for the delay |
📌 Commit 09a4d09 has been approved by |
⌛ Testing commit 09a4d09 with merge 6169aa2... |
💔 Test failed - auto-mac-64-nopt-t |
Failed in pretty. Fixed. |
@bors r=huonw |
📌 Commit ae0716d has been approved by |
Rebase of #21468.
Fix #25960.