Rollup of 6 pull requests #26028
Merged
Rollup of 6 pull requests #26028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Jun 5, 2015
steveklabnik
commented
- Successful merges: Rustdoc: Add loopcounter (enumerate) section to the for-loop chapter #25925, support aarch64-android raw type definitions #26001, Minor fix to documentation of constraints on mut/non-mut references #26010, [Documentation] Use SSL where possible, fix irc link #26011, Fix order of rustdoc highlight arguments. #26017, Doc-comment fix; trait names are capitalized #26020
- Failed merges:
Sometimes loop counters are useful and we should show new users how it is achieved in Rust.
The statement is not completely exact, because it is valid to have both 0 non-mutable references and 1 mutable reference. Instead, use the same wording as in mutability.md.
rust-example-rendered should be a class, not an id. fixes rust-lang#26013
Hi I added a little section in the for loops about the `enumerate()` function. I think it's useful for beginners to know this function and how you can use it. I used the title loopcounter, but it's probably not the best word to describe it. So let me know if there is a better word :)
fixed build fail on aarch64-android by support aarch64-android raw type definitions
The statement is not completely exact, because it is valid to have both 0 non-mutable references and 1 mutable reference. Instead, use the same wording as in mutability.md.
rust-example-rendered should be a class, not an id. fixes rust-lang#26013
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1000000 |
|
📌 Commit eb6a70c has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.