-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update authors and relnotes for 1.1 #26200
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
We should get into the habit of having a "potential breaking changes" section. Even if the section is empty for 1.1, it's good to have the section there anyway so that people know there aren't any. |
Windows, symlinks can be created with | ||
`std::os::windows::symlink_dir` and | ||
`std::os::windows::symlink_file`. | ||
* The `mpsc::Reciever` typo can now be converted into an iterator with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this should be "type" and not "typo".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Freudian slip? :) "reciever" -> "receiver", "typo" -> "type"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny.
Under compiler speed, we should also mention #25323 for its speed and memory improvements. |
@bstrie We need an appropriate way to word it. Maybe “changes to type inference”, or “minor breaking changes” |
whitespace boundaries. | ||
* The [`Iterator::cloned`] method creates an iterator of `T` from | ||
an iterator of `&T` by cloning each element. It is equivalent | ||
to `.map(|&x| x)`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think .cloned()
was already present in Rust 1.0? If not, move this down / up so that it is next to mention of Cloned
below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pedantic nit: That statement isn't quite correct. .cloned()
equivalent (<=>) to .map(|x| x.clone())
. It only replaces/supersedes .map(|&x| x)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, .cloned()
was already stable in 1.0.
I have made exactly zero language changes this cycle, sorry. edit: I guess this is release notes for the previous cycle, in which case, I think DST coercions made it in, |
|
||
* TODO: There have been changes to dropck that should probably be | ||
mentioned | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are DST coercions (#24619) in this release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging from the API docs I think so -- all the T: ?Sized
changes to Rc<T>
are in.
☔ The latest upstream changes (presumably #25844) made this pull request unmergeable. Please resolve the merge conflicts. |
This is the kind of dumb task that gets done a different way every time and is easily automated.
Rebased and addressed all comments, except that I did not add a section on breaking changes as suggested by @bstrie, though I do think we should list all breaking changes every release. We need a better way to track them. I think there were minor breaking changes this release that were considered acceptable and to affect no code, but I don't recall them offhand. |
r? @aturon |
properly exported][inc]. | ||
* [`BinaryHeap`] no longer corrupts itself [when functions called by | ||
`sift_up` or `sift_down` panic][bh]. | ||
* The [`split_off`] method of `LinkedList` [longer corrupts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer?
|
||
[fs-expand]: https://github.com/rust-lang/rust/pull/25844 | ||
* Type checking performance [has improved notably][sk] with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to call out perf improvements in the highlights section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@bors r=aturon |
📌 Commit f1a029a has been approved by |
@bors r=aturon |
📌 Commit ab0bb09 has been approved by |
[Randard](https://github.com/brson/rust/blob/relnotes/RELEASES.md). I need help identifying language things and highlights, and I am kind of tired of the `~X changes, numerous bugfixes` thing, which was cute for a few years. cc @aturon @nrc @pnkfelix
Randard.
I need help identifying language things and highlights, and I am kind of tired of the
~X changes, numerous bugfixes
thing, which was cute for a few years.cc @aturon @nrc @pnkfelix