Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors and relnotes for 1.1 #26200

Merged
merged 5 commits into from
Jun 20, 2015
Merged

Update authors and relnotes for 1.1 #26200

merged 5 commits into from
Jun 20, 2015

Conversation

brson
Copy link
Contributor

@brson brson commented Jun 11, 2015

Randard.

I need help identifying language things and highlights, and I am kind of tired of the ~X changes, numerous bugfixes thing, which was cute for a few years.

cc @aturon @nrc @pnkfelix

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 11, 2015
@bstrie
Copy link
Contributor

bstrie commented Jun 11, 2015

We should get into the habit of having a "potential breaking changes" section. Even if the section is empty for 1.1, it's good to have the section there anyway so that people know there aren't any.

Windows, symlinks can be created with
`std::os::windows::symlink_dir` and
`std::os::windows::symlink_file`.
* The `mpsc::Reciever` typo can now be converted into an iterator with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be "type" and not "typo".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Freudian slip? :) "reciever" -> "receiver", "typo" -> "type"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny.

@bstrie
Copy link
Contributor

bstrie commented Jun 11, 2015

Under compiler speed, we should also mention #25323 for its speed and memory improvements.

@bluss
Copy link
Member

bluss commented Jun 11, 2015

@bstrie We need an appropriate way to word it. Maybe “changes to type inference”, or “minor breaking changes”

whitespace boundaries.
* The [`Iterator::cloned`] method creates an iterator of `T` from
an iterator of `&T` by cloning each element. It is equivalent
to `.map(|&x| x)`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .cloned() was already present in Rust 1.0? If not, move this down / up so that it is next to mention of Cloned below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic nit: That statement isn't quite correct. .cloned() equivalent (<=>) to .map(|x| x.clone()). It only replaces/supersedes .map(|&x| x).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, .cloned() was already stable in 1.0.

@nrc
Copy link
Member

nrc commented Jun 12, 2015

I have made exactly zero language changes this cycle, sorry.

edit: I guess this is release notes for the previous cycle, in which case, I think DST coercions made it in,


* TODO: There have been changes to dropck that should probably be
mentioned

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are DST coercions (#24619) in this release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from the API docs I think so -- all the T: ?Sized changes to Rc<T> are in.

@bors
Copy link
Contributor

bors commented Jun 12, 2015

☔ The latest upstream changes (presumably #25844) made this pull request unmergeable. Please resolve the merge conflicts.

@brson
Copy link
Contributor Author

brson commented Jun 18, 2015

Rebased and addressed all comments, except that I did not add a section on breaking changes as suggested by @bstrie, though I do think we should list all breaking changes every release. We need a better way to track them. I think there were minor breaking changes this release that were considered acceptable and to affect no code, but I don't recall them offhand.

@brson
Copy link
Contributor Author

brson commented Jun 18, 2015

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned nikomatsakis Jun 18, 2015
properly exported][inc].
* [`BinaryHeap`] no longer corrupts itself [when functions called by
`sift_up` or `sift_down` panic][bh].
* The [`split_off`] method of `LinkedList` [longer corrupts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer?


[fs-expand]: https://github.com/rust-lang/rust/pull/25844
* Type checking performance [has improved notably][sk] with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to call out perf improvements in the highlights section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@brson
Copy link
Contributor Author

brson commented Jun 18, 2015

@bors r=aturon

@bors
Copy link
Contributor

bors commented Jun 18, 2015

📌 Commit f1a029a has been approved by aturon

@brson brson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 18, 2015
@brson
Copy link
Contributor Author

brson commented Jun 18, 2015

@bors r=aturon

@bors
Copy link
Contributor

bors commented Jun 18, 2015

📌 Commit ab0bb09 has been approved by aturon

@brson brson mentioned this pull request Jun 18, 2015
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 18, 2015
@bors
Copy link
Contributor

bors commented Jun 20, 2015

⌛ Testing commit ab0bb09 with merge a951569...

bors added a commit that referenced this pull request Jun 20, 2015
[Randard](https://github.com/brson/rust/blob/relnotes/RELEASES.md).

I need help identifying language things and highlights, and I am kind of tired of the `~X changes, numerous bugfixes` thing, which was cute for a few years.

cc @aturon @nrc @pnkfelix
@bors bors merged commit ab0bb09 into rust-lang:master Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.