Remove old ignored tests #26253
Merged
Remove old ignored tests #26253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these are old, but some specific messages for specific tests: * trait-contravariant-self.rs: failed due to a soundess hole: rust-lang@05e3248 * process-detatch: rust-lang@15966c3 says "this test is being ignored until signals are implemented" That's not happening for a long time, and when it is, we'll write tests for it. * deep-vector{,2}.rs: "too big for our poor macro infrastructure", and has been ignored over a year. * borrowck-nested-calls.rs's FIXME rust-lang#6268 was closed in favor of rust-lang/rfcs#811 * issue-15167.rs works properly now * issue-9737.rs works properly now * match-var-hygiene.rs works properly now Addresses a chunk of rust-lang#3965
This stdlib function went away, so update it to use current syntax.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ rollup |
|
📌 Commit 13b9a72 has been approved by |
|
wow, that's a lot of shed weight |
| @@ -15,5 +15,5 @@ | |||
| fn main() { | |||
| let x = || panic!(); | |||
| x(); | |||
| std::io::println("Foo bar"); //~ ERROR: unreachable statement | |||
| println!("Foo bar"); //~ ERROR: unreachable statement | |||
There was a problem hiding this comment.
This test is still ignored?
There was a problem hiding this comment.
yes, it is not fixed, I just updated the syntax.
bors
added a commit
that referenced
this pull request
Jun 13, 2015
Two commits here: one which removes a bunch of tests, and re-enables a few that work. Second updates the syntax of one of the failing tests. It still doesn't pass, but at least it compiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits here: one which removes a bunch of tests, and re-enables a few that work.
Second updates the syntax of one of the failing tests. It still doesn't pass, but at least it compiles.