-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Significantly simplify generic example #26323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ db0dd83c67b74b18d0fd2f19ead99360f8ec8303 rollup |
```rust,ignore | ||
// foo is generic over A and B | ||
|
||
fn foo<A, B>(x: A, y: B) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change removes the use of where
syntax referred to in the following paragraph, and the paragraph following that refers to 'iter' which is now 'foo'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argh I read it and still missed that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still referring to iter
two paragraphs down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigh. i will open a new PR to fix that.
@bors: r=alexcrichton rollup |
📌 Commit 22b6a5d has been approved by |
Fixes #26320