Fix file!(), line!() and column!() macros #26347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These used to return wrong results in case they were expanded inside compiler’s iternal syntax sugar (closures, if-let) expansions Fixes rust-lang#26322
|
@bors: r+ |
|
📌 Commit 09ed27c has been approved by |
|
triage: beta-nominated (this was a regression on nightly from stable I believe) |
rust-highfive
added
the
beta-nominated
|
@bors p=1 to get this tested so we can backport it and release the final 1.1 beta |
|
Accepting for backprot |
alexcrichton
added
the
beta-accepted
alexcrichton
removed
the
beta-nominated
zmbush
added a commit
to zmbush/rust-clippy
that referenced
this pull request
Jun 18, 2015
In rust-lang/rust#26347, MacroFormat was renamed to ExpnFormat.
zmbush
added a commit
to zmbush/rust-clippy
that referenced
this pull request
Jun 18, 2015
In rust-lang/rust#26347, MacroFormat was renamed to ExpnFormat. MacroFormat wasn't being used in src/mut_mut.rs, so I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nrc, because breakage was caused by #25318