Document behavior of bitwise operators with boolean arguments #26349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| Calls the `bitxor` method of the `std::ops::BitXor` trait. | ||
| * `<<` | ||
| : Left shift. | ||
| Calls the `shl` method of the `std::ops::Shl` trait. | ||
| * `>>` | ||
| : Right shift. | ||
| : Right shift (arithmetic). |
There was a problem hiding this comment.
we used to have arithmetic here, but iirc, @pnkfelix suggested that we remove it?
There was a problem hiding this comment.
It was incorrectly documented as logical (here's the fix: f2e0810) but it is in fact arithmetic (#23421 (comment))
|
r=me after the 'arithmetic' question is solved |
|
@bors: r+ rollup |
|
📌 Commit a8f666f has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 18, 2015
I'm surprised that bitwise operators `&`, `|` and `^` are implemented for `bool` arguments, because inspection of boolean's bits is not something that should be encouraged and because `&&` -> `&` is a common typo, but if they are implemented, then their behavior should be documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm surprised that bitwise operators
&,|and^are implemented forboolarguments, because inspection of boolean's bits is not something that should be encouraged and because&&->&is a common typo, but if they are implemented, then their behavior should be documented.