-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TLS to store a type context for pretty-printing types. #26351
Conversation
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
178a8da
to
a6c14b4
Compare
cc @rust-lang/compiler |
👍 |
☔ The latest upstream changes (presumably #26326) made this pull request unmergeable. Please resolve the merge conflicts. |
dcd2f6b
to
90d7dff
Compare
wow, this is... pretty nice. r+ from me, modulo some comments:
|
@bors r=nikomatsakis p=1 |
📌 Commit a4fef22 has been approved by |
⌛ Testing commit a4fef22 with merge 9afe8c3... |
💔 Test failed - auto-linux-64-x-android-t |
@bors r=nikomatsakis |
📌 Commit 4f5a079 has been approved by |
🔒 Merge conflict |
☔ The latest upstream changes (presumably #26192) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors r=nikomatsakis |
📌 Commit 14ce64e has been approved by |
@bors p=2 |
☔ The latest upstream changes (presumably #26147) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors r=nikomatsakis |
📌 Commit 6eed166 has been approved by |
⌛ Testing commit 6eed166 with merge 012c6ff... |
⌛ Testing commit 6eed166 with merge 8c0aa6d... |
@bors: retry force clean |
Pre-requisite for splitting the type context into global and local parts. The `Repr` and `UserString` traits were also replaced by `Debug` and `Display`.
Next step towards split local/global type contexts, after #26351. cc @rust-lang/compiler @jroesch
Pre-requisite for splitting the type context into global and local parts.
The
Repr
andUserString
traits were also replaced byDebug
andDisplay
.