Add E0128, E0130, E0134, E0135 and E0159 error explanation #26742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
changed the title
| // identifiers | ||
| ``` | ||
|
|
||
| Please verify you used the good type or change the type parameter identifier. |
There was a problem hiding this comment.
"Please verify that a name clash hasn't been accidentally introduced, and rename the type parameter if so"
GuillaumeGomez
changed the title
GuillaumeGomez
changed the title
GuillaumeGomez
changed the title
| // allowed | ||
| ``` | ||
|
|
||
| I you want to modify an str, please use the String type. Example: |
| @@ -411,6 +411,42 @@ fn main() { | |||
| See also https://doc.rust-lang.org/book/unsafe.html | |||
| "##, | |||
|
|
|||
| E0134: r##" | |||
There was a problem hiding this comment.
Aren't these error-codes borrowck's business?
|
☔ The latest upstream changes (presumably #26770) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @arielb1 |
| } | ||
| ``` | ||
|
|
||
| Please also verify that a name clash hasn't been accidentally introduced, and |
There was a problem hiding this comment.
Nit: name-clashes can't be introduced by reordering. Maybe "that this wasn't because of a name-clash".
|
@bors r+ rollup 58593c8 |
|
📌 Commit 58593c8 has been approved by |
|
@bors: r- |
|
@bors: r=arielb1 rollup |
|
📌 Commit 5460650 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 7, 2015
bors
added a commit
that referenced
this pull request
Jul 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24407.
r? @Manishearth