-
Notifications
You must be signed in to change notification settings - Fork 13.3k
librustdoc: blur page when help dialogue is present #26887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I like this idea, and think it looks fine, but am terrible at CSS and would like @gankro or @alexcrichton to check it too. |
I’m sure it can be done in cleverer ways. I just realised this patch also fixes the positioning of the dialogue as you scroll. It relies on flexbox, which by now should be available in all major browsers, to centre the box vertically as well as horizontally. |
Could you post this on a site to poke around on? Also is this supported in most browsers? |
#help { | ||
width: 100%; | ||
height: 100vh; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind: blown
Everything I know about HTML and CSS I learned in 1997. r? @alexcrichton |
@bors: r+ 0baadfc34e6afc679043d280a1c6b7b47bf3c8a4 Nice! |
🔒 Merge conflict |
According to caniuse, |
☔ The latest upstream changes (presumably #26913) made this pull request unmergeable. Please resolve the merge conflicts. |
@andreastt needs a rebase :) |
@steveklabnik Just got back from holiday 🌴 |
Blurs the document's background when the help dialogue is present, making the contents of the dialogue stand out more.
@P1start Thanks, added the prefix! |
@bors: r+ |
📌 Commit 6b64826 has been approved by |
@andreastt nice, hope you had a good time :) |
Blurs the document's background when the help dialogue is present, making the contents of the dialogue stand out more.
Blurs the document's background when the help dialogue is present,
making the contents of the dialogue stand out more.