Skip to content

librustdoc: blur page when help dialogue is present #26887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2015
Merged

librustdoc: blur page when help dialogue is present #26887

merged 1 commit into from
Jul 20, 2015

Conversation

andreastt
Copy link
Contributor

Blurs the document's background when the help dialogue is present,
making the contents of the dialogue stand out more.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

I like this idea, and think it looks fine, but am terrible at CSS and would like @gankro or @alexcrichton to check it too.

@andreastt
Copy link
Contributor Author

I’m sure it can be done in cleverer ways. I just realised this patch also fixes the positioning of the dialogue as you scroll. It relies on flexbox, which by now should be available in all major browsers, to centre the box vertically as well as horizontally.

@alexcrichton
Copy link
Member

Could you post this on a site to poke around on? Also is this supported in most browsers?

#help {
width: 100%;
height: 100vh;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind: blown

@nikomatsakis
Copy link
Contributor

Everything I know about HTML and CSS I learned in 1997. r? @alexcrichton

@andreastt
Copy link
Contributor Author

@alexcrichton

Before:
Before
After:
After

@alexcrichton
Copy link
Member

@bors: r+ 0baadfc34e6afc679043d280a1c6b7b47bf3c8a4

Nice!

@bors
Copy link
Collaborator

bors commented Jul 11, 2015

🔒 Merge conflict

@ftxqxd
Copy link
Contributor

ftxqxd commented Jul 11, 2015

According to caniuse, filter requires a -webkit- prefix to support Chrome (and other WebKit browsers).

@bors
Copy link
Collaborator

bors commented Jul 12, 2015

☔ The latest upstream changes (presumably #26913) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik
Copy link
Member

@andreastt needs a rebase :)

@andreastt
Copy link
Contributor Author

@steveklabnik Just got back from holiday 🌴

Blurs the document's background when the help dialogue is present,
making the contents of the dialogue stand out more.
@andreastt
Copy link
Contributor Author

@P1start Thanks, added the prefix!

@steveklabnik
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jul 20, 2015

📌 Commit 6b64826 has been approved by steveklabnik

@steveklabnik
Copy link
Member

@andreastt nice, hope you had a good time :)

@bors
Copy link
Collaborator

bors commented Jul 20, 2015

⌛ Testing commit 6b64826 with merge 4e51763...

bors added a commit that referenced this pull request Jul 20, 2015
Blurs the document's background when the help dialogue is present,
making the contents of the dialogue stand out more.
@bors bors merged commit 6b64826 into rust-lang:master Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants