std: Consider directory junctions as directories #26929
Merged
+225
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @retep998 |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
windows-dir-junction
branch
from
fe48561 to
b612d3b
Compare
|
@bors r+ dammit windows |
|
📌 Commit b612d3b has been approved by |
|
☔ The latest upstream changes (presumably #26751) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Sorry for the merge conflicts 😛 |
Previously on Windows a directory junction would return false from `is_dir`, causing various odd behavior, specifically calls to `create_dir_all` might fail when they would otherwise continue to succeed. Closes rust-lang#26716
alexcrichton
force-pushed
the
windows-dir-junction
branch
from
b612d3b to
72750c7
Compare
|
⌛ Testing commit 72750c7 with merge 30aeaba... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry On Fri, Jul 10, 2015 at 5:01 PM, bors notifications@github.com wrote:
|
bors
added a commit
that referenced
this pull request
Jul 11, 2015
Previously on Windows a directory junction would return false from `is_dir`, causing various odd behavior, specifically calls to `create_dir_all` might fail when they would otherwise continue to succeed. Closes #26716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on Windows a directory junction would return false from
is_dir,causing various odd behavior, specifically calls to
create_dir_allmight failwhen they would otherwise continue to succeed.
Closes #26716