Implement RFC 1058 #26966
Merged
Implement RFC 1058 #26966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
nagisa
force-pushed
the
tail-init
branch
6 times, most recently
from
cbfce11
to
8418fe9
Compare
| @@ -280,34 +280,34 @@ impl<T> [T] { | |||
| core_slice::SliceExt::first_mut(self) | |||
| } | |||
|
|
|||
| /// Returns all but the first element of a slice. | |||
| #[unstable(feature = "slice_extras", reason = "likely to be renamed")] | |||
| /// Returns the first and all the rest elements of a slice. | |||
There was a problem hiding this comment.
s/rest elements/rest of the elements/
| /// Returns all but the first element of a slice. | ||
| #[unstable(feature = "slice_extras", reason = "likely to be renamed")] | ||
| /// Returns the first and all the rest of the elements of a slice. | ||
| #[stable(feature = "rfc1058", since = "1.3.0")] |
There was a problem hiding this comment.
This is a fairly significant change in terms of functionality so I don't think we should insta-stabilize these methods (e.g. leave them as #[unstable] for a little longer). Could you also give it a more descriptive feature name than "rfc1058"? Just to help error messages and such later on down the road.
Finally, could you leave the old tail methods and such, but #[deprecate] them in favor of these new methods?
|
Thanks @nagisa! |
nagisa
force-pushed
the
tail-init
branch
2 times, most recently
from
9cff581
to
db8d3cd
Compare
|
Comments addressed. |
bors
added a commit
that referenced
this pull request
Jul 12, 2015
|
⌛ Testing commit 7a90865 with merge 50d305e... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26906