graphviz: support style attributes #27044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| impl LabelledGraph { | ||
| fn new(name: &'static str, | ||
| node_labels: Trivial, | ||
| edges: Vec<Edge>) -> LabelledGraph { | ||
| edges: Vec<Edge>, | ||
| node_styles: Vec<Style>) -> LabelledGraph { |
There was a problem hiding this comment.
could you make the node_styles an Option<Vec<Style>> instead? In your tests, it seemed annoying to construct the vecs of no-style so frequently.
|
@nrc looks fine. I trust you to make your own call regarding my suggestion about the API change. r=me after that is or is not addressed. :) |
|
So I ended up making the ctor take an Option rather than changing the field. I think that gives us the best of both worlds. |
|
📌 Commit 75f8f96 has been approved by |
oh great, changing the ctor was actually what I was intending. :) |
bors
added a commit
that referenced
this pull request
Jul 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @pnkfelix