-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve register_diagnostics macro #27067
Conversation
you can also make the comma required by changing the existing thing to |
I can add this "feature" for others too, of course. However, I like to have choice to finish the macro with or without a comma. Let's see others' opinions. |
This looks fine to me. The Rust Way is to always allow trailing comma but never require it, so this seems consistent with that. |
@bors: r+ rollup |
📌 Commit a5d8c43 has been approved by |
@bors: r- (pending more changes) |
@bors: r+ rollup |
📌 Commit 6e58043 has been approved by |
⌛ Testing commit 6e58043 with merge b429d3d... |
💔 Test failed - auto-mac-64-nopt-t |
@bors: retry On Fri, Jul 17, 2015 at 7:27 AM, bors notifications@github.com wrote:
|
⌛ Testing commit 6e58043 with merge 0062146... |
💔 Test failed - auto-linux-64-nopt-t |
@bors: retry On Fri, Jul 17, 2015 at 8:31 AM, bors notifications@github.com wrote:
|
Merged in #27098. I close. |
Now the macro argument list can be finished by a comma (not sure this is correct english...).
cc @tamird
r? @bluss