-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add separate errors for out-of-place associated consts and types #27120
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
r? @nagisa |
/// error E0437: type is not a member of trait | ||
TypeNotMemberOfTrait(Name, &'a str), | ||
/// error E0438: const is not a member of trait | ||
ConstNotMemberOfTrait(Name, &'a str), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I’d group related enum variants together by purpose rather than error code. That is, it would be easier to read the code if MethodNotMemberOfTrait
, TypeNotMemberOfTrait
and ConstNotMemberOfTrait
were all adjacent to each other.
Baring the nits, LGTM. |
Previously, these would both be labeled as methods.
Nits addressed and rebased. |
⌛ Testing commit ce856a5 with merge ef04b07... |
Previously, these would both be labeled as methods.
Previously, these would both be labeled as methods.