add separate errors for out-of-place associated consts and types #27120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @nagisa |
| /// error E0437: type is not a member of trait | ||
| TypeNotMemberOfTrait(Name, &'a str), | ||
| /// error E0438: const is not a member of trait | ||
| ConstNotMemberOfTrait(Name, &'a str), |
There was a problem hiding this comment.
Nit: I’d group related enum variants together by purpose rather than error code. That is, it would be easier to read the code if MethodNotMemberOfTrait, TypeNotMemberOfTrait and ConstNotMemberOfTrait were all adjacent to each other.
|
Baring the nits, LGTM. |
Previously, these would both be labeled as methods.
|
Nits addressed and rebased. |
|
⌛ Testing commit ce856a5 with merge ef04b07... |
bors
added a commit
that referenced
this pull request
Jul 20, 2015
Previously, these would both be labeled as methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these would both be labeled as methods.