Add long diagnostics for E0382 #27182
Conversation
| that at most one writer or multiple readers can access the data at any one time. | ||
|
|
||
| If you wish to learn more about ownership in Rust, start with the chapter in the | ||
| Book: |
There was a problem hiding this comment.
Since it's supposed to be full markdown, I'm wondering if we should create urls like markdown : [Book](https://doc.rust-lang.org/book/ownership.html).
There was a problem hiding this comment.
Not sure - on the one hand, it's markdown, on the other hand, I imagine it'll look pretty weird when we print the message via rustc?
There was a problem hiding this comment.
I'm working on this issue to print it directly markdown formatted (it's been a while however, too much things to do...).
There was a problem hiding this comment.
Links can't be formatted in terminal output, so we should only use footnote-style notation for them
There was a problem hiding this comment.
So, am I okay to leave this as-is, or should I change it to footnote style?
|
☔ The latest upstream changes (presumably #27265) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@AlisdairO: A little rebased is needed here for r+. |
|
Before I rebase this one, just want to check that it's wanted/correct? Perfectly happy to keep working on it if needed, but I'm not sure where this PR is going right now. |
|
Seems good for me, you'll need someone else's opinion. :) |
| of `x` when we set `y`. This is fundamental to Rust's ownership system: outside | ||
| of workarounds like `Rc`, a value cannot be owned by more than one variable. | ||
|
|
||
| The easiest way to address this problem is to implement `Copy` and `Clone` on |
|
Yes, we want this, thanks for the effort 😄 (just needs rebase and one optional nit and should be good to go) |
AlisdairO
force-pushed
the
diagnostics382
branch
from
98a00c8 to
dadc717
Compare
|
Fab, thanks a lot :). Rebased. |
|
@bors r+ rollup |
|
📌 Commit dadc717 has been approved by |
As title :-) Part of #24407. r? @Manishearth
As title :-)
Part of #24407.
r? @Manishearth