-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup configure nits #27331
Cleanup configure nits #27331
Conversation
This is just a small nit.
This puts the important information at the top of the file and so makes the configure script easier to understand.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
r? @brson |
☔ The latest upstream changes (presumably #27250) made this pull request unmergeable. Please resolve the merge conflicts. |
…up-configure-nits Conflicts: configure
☔ The latest upstream changes (presumably #27173) made this pull request unmergeable. Please resolve the merge conflicts. |
…up-configure-nits Conflicts: configure
I did make this ready merge and change the parts talked about. |
I haven't seen this PR before. Will review tomorrow. |
☔ The latest upstream changes (presumably #27630) made this pull request unmergeable. Please resolve the merge conflicts. |
r=me I'm sorry I forgot about this. |
needs a rebase |
Closing due to inactivity, but feel free to resend with a rebase! |
So, I'm doing more things to cleanup the configure script.