rustc: rename multiple imports in a list #27451
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -2430,11 +2430,11 @@ pub struct ViewListIdent { | |||
| impl Clean<ViewListIdent> for ast::PathListItem { | |||
| fn clean(&self, cx: &DocContext) -> ViewListIdent { | |||
| match self.node { | |||
| ast::PathListIdent { id, name } => ViewListIdent { | |||
| ast::PathListIdent { id, name, .. } => ViewListIdent { | |||
There was a problem hiding this comment.
I think these cases need to be handled to show reexports correctly, this will probably need to update the ViewListIdent structures here, and can you be sure to add a rustdoc test for this?
There was a problem hiding this comment.
OH, I misunderstood what this code did. Re-exports, of course.
|
Can you be sure to add some more exhaustive tests for this? It looks like this only includes "this will parse" tests rather than "this will resolve" tests along with tests for things like error messages (e.g. an item doesn't exist in a module). |
|
Ah, you're right, that test doesn't test it resolved the correct item.
@alexcrichton I assumed those tests already exist as normal importing tests. |
|
They probably do exist, but new ones should be added for this new feature. This should be as exhaustively tested as possible, basically, because although the implementation may be simple today a later refactoring will benefit from an exhaustive set of tests. |
seanmonstar
force-pushed
the
use-groups-as
branch
6 times, most recently
from
670aaf6
to
e042365
Compare
|
@alexcrichton i've fixed up rustdoc and some error tests. some other specific tests you have in mind? I |
|
This needs a |
|
parser-lalr.y probably needs changing to pass tests too |
|
@Manishearth a change in In other words, |
|
Visit both. visit.rs is for AST visiting, so anything in the AST should get visited |
seanmonstar
force-pushed
the
use-groups-as
branch
from
e042365
to
47d963f
Compare
|
@Manishearth like so? |
|
Yep! |
seanmonstar
force-pushed
the
use-groups-as
branch
from
47d963f
to
cfcd449
Compare
|
All looks good to me, thanks @seanmonstar! |
An implementation of [RFC 1219](rust-lang/rfcs#1219). The RFC is not merged yet, but once merged, this could be.
bluss
added
the
relnotes
An implementation of RFC 1219.
The RFC is not merged yet, but once merged, this could be.