Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use https URLs to refer to rust-lang.org where appropriate. #27622

Merged
merged 2 commits into from
Aug 12, 2015
Merged

Use https URLs to refer to rust-lang.org where appropriate. #27622

merged 2 commits into from
Aug 12, 2015

Conversation

eefriedman
Copy link
Contributor

Also fixes a few outdated links.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik
steveklabnik reviewed Aug 9, 2015
View reviewed changes
src/doc/style/features/functions-and-methods/input.md
@@ -156,8 +156,7 @@ over
fn foo(a: u8) { ... }
```

Note that
[`ascii::Ascii`](http://static.rust-lang.org/doc/master/std/ascii/struct.Ascii.html)
Note that `ascii::Ascii`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why lose the link here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ascii::Ascii no longer exists in the standard library.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we probably should remove this bit entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can rewrite it, I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced ascii::Ascii with a different example.

@alexcrichton
Copy link
Member

@bors: r+ 7d3c4bd

Thanks!

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 12, 2015
@alexcrichton
rollup merge of rust-lang#27622: eefriedman/https-url
737397c 
Also fixes a few outdated links.
@bors
Copy link
Contributor

bors commented Aug 12, 2015

⌛ Testing commit 7d3c4bd with merge 89ab4a2...

@bors
Copy link
Contributor

bors commented Aug 12, 2015

💔 Test failed - auto-linux-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Aug 12, 2015 at 4:36 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/6019

—
Reply to this email directly or view it on GitHub
#27622 (comment).

@bors bors merged commit 7d3c4bd into rust-lang:master Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eefriedman @rust-highfive @alexcrichton @bors @steveklabnik @brson