-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make tidy-binaries find invocation work on Linux #27625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New enough find on Linux doesn't support "-perm +..." and suggests using "-perm /..." instead, but that doesn't work on Windows. Hopefully all platforms are happy with this expanded version.
(rust_highfive has picked a reviewer for you, use r? to override) |
This invocation is notoriously difficult to get right as I think this is probably the 10th PR related to trying to touch up these flags. Can you confirm:
It... may be better to just rewrite this in python. |
On Gentoo Linux:
I don't have rust checkouts on other machines to test, but I verified that when run on a directory
(with a few irrelevant variations like
is the same on Gentoo, Ubuntu 14.04.2 LTS, Debian GNU/Linux 8.1 (jessie), Red Hat Enterprise Linux Server release 5.9 (Tikanga), Mac OS X 10.7.5, and FreeBSD 10.0.
That would also be reasonable, but I'm not very good with python so you don't want me doing it. |
New enough find on Linux doesn't support "-perm +..." and suggests using "-perm /..." instead, but that doesn't work on Windows. Hopefully all platforms are happy with this expanded version. I don't have access to a Windows development system to test this, so someone needs to verify that this actually works there before merging. Closes rust-lang#19981.
⌛ Testing commit f001f9a with merge 170fb84... |
💔 Test failed - auto-win-gnu-32-opt |
I bet the Windows build is unhappy with that file because it looks like it starts with a #! line. I'm not sure why that matches now but not with the old find invocation, but it seems reasonable to me to just add '*.pp' to the extension whitelist. |
Pretty-printed files sometimes start with #![some_feature], which looks like a shebang line and confuses Windows builds into thinking they are executables.
New enough find on Linux doesn't support "-perm +..." and suggests using "-perm /..." instead, but that doesn't work on Windows. Hopefully all platforms are happy with this expanded version. I don't have access to a Windows development system to test this, so someone needs to verify that this actually works there before merging. Closes #19981.
New enough find on Linux doesn't support "-perm +..." and suggests
using "-perm /..." instead, but that doesn't work on Windows.
Hopefully all platforms are happy with this expanded version.
I don't have access to a Windows development system to test this, so someone needs to verify that this actually works there before merging.
Closes #19981.