Rename String::into_boxed_slice -> into_boxed_str #27696
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
This is a breaking-change for anyone using |
alexcrichton
added
the
T-libs-api
|
Gah oops! Can you also leave behind the old method as deprecated? |
|
Ok. Didn't think it was an issue, since it's unstable & recent. Will do. |
This is the name that was decided in rust-lang/rfcs#1152, and it's better if we say “boxed str” for `Box<str>`. The old name `String::into_boxed_slice` is deprecated.
|
Updated to leave the old name in, deprecated. Thus it's not a breaking change, but it introduces a deprecation. |
|
Thank you! |
Rename String::into_boxed_slice -> into_boxed_str This is the name that was decided in rust-lang/rfcs#1152, and it's better if we say “boxed str” for `Box<str>`. The old name `String::into_boxed_slice` is deprecated.
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry Nothing like causing a bus error in the linker |
|
⚡ Previous build results for auto-win-msvc-32-opt, auto-win-msvc-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry On Thu, Aug 13, 2015 at 1:34 PM, bors notifications@github.com wrote:
|
Rename String::into_boxed_slice -> into_boxed_str This is the name that was decided in rust-lang/rfcs#1152, and it's better if we say “boxed str” for `Box<str>`. The old name `String::into_boxed_slice` is deprecated.
Rename String::into_boxed_slice -> into_boxed_str
This is the name that was decided in rust-lang/rfcs#1152, and it's
better if we say “boxed str” for
Box<str>.The old name
String::into_boxed_sliceis deprecated.