Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with for loop expansion #27827

Merged
merged 1 commit into from Aug 15, 2015
Merged

Fix issue with for loop expansion #27827

merged 1 commit into from Aug 15, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 14, 2015

Fixes #27639

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks! Could you also squash the commits together? Other than that though r=me

@ghost
Copy link
Author

ghost commented Aug 15, 2015

Squashed!

@bluss
Copy link
Member

bluss commented Aug 15, 2015

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Aug 15, 2015

📌 Commit ae68e90 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 15, 2015

⌛ Testing commit ae68e90 with merge 2945555...

@bors bors merged commit ae68e90 into rust-lang:master Aug 15, 2015
@ghost ghost deleted the for-loop-expn-issue-27639 branch August 31, 2015 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants