be more robust to bogus items in struct patterns/constructors #27833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
force-pushed
the
robust-construction
branch
from
4ec8172 to
b87c292
Compare
| // isn't a structure! | ||
| ``` | ||
| // or even simpler, if the name doesn't refer to a structure at all. | ||
| let t = u32 { value: 4 }; // error: `u32` does not name a structure.``` |
There was a problem hiding this comment.
Shouldn't the closing ``` be on its own line?
|
r=me with nit fixed (if necessary). |
This fixes the crazy "transparent aliases" bug, which I hope nobody relied on.
|
Added commits for #27831 @alexcrichton: could you do a crater run? |
|
Hm, looks like this may not bootstrap right now? https://tools.taskcluster.net/task-inspector/#Y9JMVRF4QKu6-yJwv8x3Wg/0 |
|
fixed that, sorry. |
arielb1
force-pushed
the
robust-construction
branch
2 times, most recently
from
c2187ee to
9415c70
Compare
also, make sure this is tested.
arielb1
force-pushed
the
robust-construction
branch
from
9415c70 to
44f4106
Compare
|
Crater reports zero regressions (belatedly) |
|
r? @eddyb |
|
@bors r+ |
|
📌 Commit 44f4106 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27815
r? @eddyb