make trait matching smarter with projections #27866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
force-pushed
the
really-fast-reject
branch
from
e93d01d
to
953c40b
Compare
|
r+ modulo arielb1@e93d01d#commitcomment-12744047 |
arielb1
force-pushed
the
really-fast-reject
branch
2 times, most recently
from
9e2578e
to
e3b1257
Compare
added 2 commits
August 17, 2015 21:53
also, use the right caching logic for type_moves_by_default (this was broken by @jroesch). before: 593.10user 5.21system 7:51.41elapsed 126%CPU (0avgtext+0avgdata 1150016maxresident)k llvm: 427.045 after: 577.76user 4.27system 7:36.13elapsed 127%CPU (0avgtext+0avgdata 1141608maxresident)k llvm: 431.001
this doesn't cause a measurable perf increase, but it makes callgrind output cleaner. Anyway, rustc should be using FNV everywhere.
arielb1
force-pushed
the
really-fast-reject
branch
from
e3b1257
to
96e6b2f
Compare
|
added comment. |
|
I have some reasons to suspect this doesn't completely work. Investigating. |
arielb1
force-pushed
the
really-fast-reject
branch
from
73ef21b
to
7eccece
Compare
|
fixed that |
added 2 commits
August 18, 2015 00:24
this avoids needless substituting before: 577.76user 4.27system 7:36.13elapsed 127%CPU (0avgtext+0avgdata 1141608maxresident)k after: 573.01user 4.04system 7:33.86elapsed 127%CPU (0avgtext+0avgdata 1141656maxresident)k
before: 573.01user 4.04system 7:33.86elapsed 127%CPU (0avgtext+0avgdata 1141656maxresident)k after: 567.03user 4.00system 7:28.23elapsed 127%CPU (0avgtext+0avgdata 1133112maxresident)k an additional 1% improvement
arielb1
force-pushed
the
really-fast-reject
branch
from
7eccece
to
13809ff
Compare
|
@bors r+ |
|
📌 Commit 13809ff has been approved by |
bors
added a commit
that referenced
this pull request
Aug 18, 2015
also, use the right caching logic for type_moves_by_default (this was broken by @jroesch). ``` before: 593.10user 5.21system 7:51.41elapsed 126%CPU (0avgtext+0avgdata 1150016maxresident)k after: 567.03user 4.00system 7:28.23elapsed 127%CPU (0avgtext+0avgdata 1133112maxresident)k ``` A nice 4.5% improvement. For reference, on the last run LLVM takes 429.267s, which is 75% - hopefully this can be reduced. I think the regression since #27751 is because of the wf patch - need to investigate it through. r? @nikomatsakis
bluss
added
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, use the right caching logic for type_moves_by_default (this was
broken by @jroesch).
A nice 4.5% improvement. For reference, on the last run LLVM takes 429.267s, which is 75% - hopefully this can be reduced.
I think the regression since #27751 is because of the wf patch - need to investigate it through.
r? @nikomatsakis