Fix for issue #27889: same field names in enum variants #27929
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I would prefer to make |
|
r? @nrc |
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| // pretty-expanded FIXME #27889 |
There was a problem hiding this comment.
Could you change this comment to describe what is actually being tested please? What is the connection with pretty-expanded?
|
This lgtm, modulo the comments. @pnkfelix could you have a quick look please, just to check if there is perhaps a better way of doing this? |
|
What's the status of this? |
|
ping @pnkfelix |
|
r? @pnkfelix |
|
@bors r+ 7482877 |
|
⌛ Testing commit 7482877 with merge f1cb624... |
|
💔 Test failed - auto-win-msvc-64-opt |
|
(needs a rebase, based on the error message... r=me once that happens...) |
|
Rebased |
|
@bors r+ |
|
📌 Commit 43725dc has been approved by |
|
⌛ Testing commit 43725dc with merge 9d5a3ef... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry On Fri, Dec 11, 2015 at 11:45 PM, bors notifications@github.com wrote:
|
Fix for issue #27889: same field names in enum variants
Fix for issue #27889: same field names in enum variants