Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book: Talk about ignore attribute in testing guide #27968

Merged
merged 3 commits into from
Aug 25, 2015

Conversation

adamcrume
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

# The `ignore` attribute

Sometimes a few specific tests can be very time-consuming to execute. These
can be disabled by default by using the `ignore` attribute:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execute. These

Is there a precedence in the book for double spaces after sentence ends?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be only one space.

@killercup
Copy link
Member

Good addition. I'd probably try to explain that --ignored is a flag on the test binary (not cargo) to avoid confusion over why there is an additional -- between test and the argument.

@steveklabnik
Copy link
Member

@adamcrume Both of @killercup 's points are valid, but I think they're small enough that if you weren't willing to make them, we can take this as-is anyway. Let me know what you think either way :)

@adamcrume
Copy link
Contributor Author

@steveklabnik I'm happy to make the changes. I'll have free time to work on it this evening.

@killercup
Copy link
Member

LGTM, @adamcrume.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 25, 2015

📌 Commit 574deb7 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thanks so much!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 25, 2015
bors added a commit that referenced this pull request Aug 25, 2015
@bors bors merged commit 574deb7 into rust-lang:master Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants