Skip to content

Improve --test interaction with entry points #27992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 26, 2015
Merged

Improve --test interaction with entry points #27992

merged 4 commits into from
Aug 26, 2015

Conversation

wthrowe
Copy link
Contributor

@wthrowe wthrowe commented Aug 25, 2015

wthrowe added 4 commits August 24, 2015 20:27
@wthrowe
Move entry point identification logic to libsyntax
45de9de 
Identifying entry points will be useful in --test mode, which is
handled in libsyntax.
@wthrowe
Mark main-like functions allow(dead_code) in tests
15d6837 
Fixes rust-lang#12327.
@wthrowe
Move main removal to its own pass in --test mode
0112e7b 
This handles the case where the #[main] function is buried deeper in
the ast than we search for #[test] functions.  I'm not sure why one
would want to do that, but since it works in standard compilation it
should also work for tests.
@wthrowe
Remove #[start] as well as #[main] in --test
8320a3a 
Fixes rust-lang#11766.
@rust-highfive
Copy link
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 8320a3a

Thanks!

bors added a commit that referenced this pull request Aug 26, 2015
@bors
Auto merge of #27992 - wthrowe:dead-main-2, r=alexcrichton
a48c29d 
* Suppresses warnings that main is unused when testing (#12327)
* Makes `--test` work with explicit `#[start]` (#11766)
* Fixes some cases where the normal main would not be disabled by `--test`, resulting in compilation failures.
@bors
Copy link
Collaborator

bors commented Aug 26, 2015

⌛ Testing commit 8320a3a with merge a48c29d...

@bors
Copy link
Collaborator

bors commented Aug 26, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 8320a3a into rust-lang:master Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@huonw huonw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wthrowe @rust-highfive @alexcrichton @bors @huonw