-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement RFC 1194 #28043
implement RFC 1194 #28043
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
r? @gankro |
/// The value may be any borrowed form of the set's value type, but | ||
/// `Hash` and `Eq` on the borrowed form *must* match those for | ||
/// the value type. | ||
#[unstable(feature = "set_recovery", issue = "0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just to make sure this comment isn't lost)
These issues can be wired up to the tracking issue for the RFC now
Thanks @apasel422! Was this also going to take care of |
I just haven't gotten around to making the changes for BTreeSet. I'll On Thursday, August 27, 2015, Alex Crichton notifications@github.com
|
Ok, well in the meantime these look good to me :) |
Updated with correct issue numbers and |
Leaf(_) => return None, | ||
Internal(internal_handle) => { | ||
cur_node = internal_handle.into_edge(); | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this continue
can be omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually copied from BTreeMap::get
, so I opted to keep the code as similar as possible.
Thanks @apasel422! |
closes #28050