Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement RFC 1194 #28043

Merged
merged 1 commit into from
Aug 29, 2015
Merged

implement RFC 1194 #28043

merged 1 commit into from
Aug 29, 2015

Conversation

apasel422
Copy link
Contributor

closes #28050

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Aug 27, 2015

r? @gankro

@rust-highfive rust-highfive assigned Gankra and unassigned brson Aug 27, 2015
/// The value may be any borrowed form of the set's value type, but
/// `Hash` and `Eq` on the borrowed form *must* match those for
/// the value type.
#[unstable(feature = "set_recovery", issue = "0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just to make sure this comment isn't lost)

These issues can be wired up to the tracking issue for the RFC now

@alexcrichton
Copy link
Member

Thanks @apasel422! Was this also going to take care of BTreeSet? Or is that holding off for future changes?

@apasel422
Copy link
Contributor Author

I just haven't gotten around to making the changes for BTreeSet. I'll
update this PR once I have.

On Thursday, August 27, 2015, Alex Crichton notifications@github.com
wrote:

Thanks @apasel422 https://github.com/apasel422! Was this also going to
take care of BTreeSet? Or is that holding off for future changes?


Reply to this email directly or view it on GitHub
#28043 (comment).

@alexcrichton
Copy link
Member

Ok, well in the meantime these look good to me :)

@apasel422 apasel422 changed the title WIP: implement RFC 1194 implement RFC 1194 Aug 28, 2015
@apasel422
Copy link
Contributor Author

Updated with correct issue numbers and BTreeSet methods.

Leaf(_) => return None,
Internal(internal_handle) => {
cur_node = internal_handle.into_edge();
continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this continue can be omitted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually copied from BTreeMap::get, so I opted to keep the code as similar as possible.

@alexcrichton
Copy link
Member

@bors: r+ f9b63d3

Thanks @apasel422!

@bors
Copy link
Contributor

bors commented Aug 29, 2015

⌛ Testing commit f9b63d3 with merge d503524...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set recovery methods
6 participants