std: Run TLS destructors in a statically linked binary #28130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
alexcrichton
force-pushed
the
fix-msvc-static-tls-dtor
branch
from
2a30798 to
0a4d162
Compare
|
r=me w/ comment addressed |
alexcrichton
force-pushed
the
fix-msvc-static-tls-dtor
branch
from
0a4d162 to
15820f0
Compare
|
@bors: r=brson 15820f0f6d317992329c6e0a138b4870ca548992 |
|
⌛ Testing commit 15820f0 with merge 407d811... |
|
💔 Test failed - auto-win-msvc-32-opt |
Running TLS destructors for a MSVC Windows binary requires the linker doesn't elide the `_tls_used` or `__tls_used` symbols (depending on the architecture). This is currently achieved via a `#[link_args]` hack but this only works for dynamically linked binaries because the link arguments aren't propagated to statically linked binaries. This commit alters the strategy to instead emit a volatile load from those symbols so LLVM can't elide it, forcing the reference to the symbol to stay alive as long as the callback function stays alive (which we've made sure of with the `#[linkage]` attribute). Closes rust-lang#28111
alexcrichton
force-pushed
the
fix-msvc-static-tls-dtor
branch
from
15820f0 to
9a3acec
Compare
bors
added a commit
that referenced
this pull request
Sep 1, 2015
Running TLS destructors for a MSVC Windows binary requires the linker doesn't elide the `_tls_used` or `__tls_used` symbols (depending on the architecture). This is currently achieved via a `#[link_args]` hack but this only works for dynamically linked binaries because the link arguments aren't propagated to statically linked binaries. This commit alters the strategy to instead emit a volatile load from those symbols so LLVM can't elide it, forcing the reference to the symbol to stay alive as long as the callback function stays alive (which we've made sure of with the `#[linkage]` attribute). Closes #28111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running TLS destructors for a MSVC Windows binary requires the linker doesn't
elide the
_tls_usedor__tls_usedsymbols (depending on the architecture).This is currently achieved via a
#[link_args]hack but this only works fordynamically linked binaries because the link arguments aren't propagated to
statically linked binaries.
This commit alters the strategy to instead emit a volatile load from those
symbols so LLVM can't elide it, forcing the reference to the symbol to stay
alive as long as the callback function stays alive (which we've made sure of
with the
#[linkage]attribute).Closes #28111