Add help notes (and improve some error explanations too) #28231
Conversation
| msg.description()); | ||
| span_help!(self.tcx.sess, msg.span, | ||
| "Dividing by 0 always leads to an error and is \ | ||
| certainly not what you want"); |
There was a problem hiding this comment.
"certainly not what you want" doesn't sound like a nice way to phrase it. In this case, there's no single suggestion for fixing that stands out, so we shouldn't be adding this help in the first place (that's what the long diagnostics are for)
There was a problem hiding this comment.
In this case, I found it useful because there is no case you might want to divide by 0. So instead of removing it, do you have a better sentence maybe ?
There was a problem hiding this comment.
But that's the point. In this case from the error itself that one should somehow fix it. This line doesn't really suggest anything and restates the obvious.
There was a problem hiding this comment.
Okay, I remove this one then.
|
r+ after you remove the first span_help |
GuillaumeGomez
force-pushed
the
help_note
branch
from
af47cc4 to
771ab35
Compare
|
@Manishearth: Done ! |
|
@bors r+ rollup |
|
📌 Commit 771ab35 has been approved by |
r? @Manishearth