-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more traits for function pointers #28268
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Can you measure the metadata size before/after this patch? I'm a little worried about these being so rarely used but having a relatively significant cost in terms of metadata size. |
Size of libcore.rlib: |
How about we stick to just Rust, C, and <5 arguments for now? I think we can also cut down on the number of traits implemented to the bare bones as well, I don't think these necessarily need to be at the same parity as raw pointers (e.g. are we really using function pointers as keys in hash maps?). |
Good, it was the back-up plan from the beginning.
We aren't, because they don't implement
I'd prefer not to do this, libcore size is not a holy grail after all. What increase in size of libcore do you consider acceptable? |
⌛ Testing commit bc7c430 with merge bf60883... |
💔 Test failed - auto-win-gnu-64-opt |
@bors: retry On Mon, Sep 14, 2015 at 6:38 PM, bors notifications@github.com wrote:
|
Implement traits for variadic function pointers Closes #34874 cc #28268 r? @alexcrichton
Closes #26082