Rollup of 5 pull requests #28311
Closed
Rollup of 5 pull requests #28311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Sep 9, 2015
Manishearth
commented
- Successful merges: fix punctuation in list #28281, fix capitalization inside sentense #28283, Fix link to hygienic macros on Wikipedia #28294, Fix small sentence about references #28295, Remove references to removed Valgrind headers #28305
- Failed merges:
…st a slice
This can be shown with the example code
```rust
fn main() {
let () = include_bytes!("/etc/hosts");
}
Which will have the error:
expected `&[u8; 195]`,
found `()`
Thanks Eric, reported via email
…bnik The link address is defined below the paragraph so no need to have it inline.
…ichton Thanks Eric, reported via email
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 |
|
📌 Commit 6a03830 has been approved by |
…excrichton
This can be shown with the example code
```rust
fn main() {
let () = include_bytes!(\"/etc/hosts\");
}
Which will have the error:
expected `&[u8; 195]`,
found `()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.