Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blanket impl for &mut std::fmt::Write #28368

Merged
merged 1 commit into from
Sep 14, 2015
Merged

Add a blanket impl for &mut std::fmt::Write #28368

merged 1 commit into from
Sep 14, 2015

Conversation

lambda-fairy
Copy link
Contributor

There is already a corresponding impl for std::io::Write. This change
will make the two traits more consistent.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Thanks! Can you also tag this as #[stable(since = "1.4.0")]? Could you also remove the #[inline] tags? Those shouldn't be necessary as this implementation will be monomorphized already and LLVM has all the info it needs.

@lambda-fairy
Add a blanket impl for &mut std::fmt::Write
2305dc0 
There is already a corresponding impl for `std::io::Write`. This change
will make the two traits more consistent.
@lambda-fairy
Copy link
Contributor Author

@alexcrichton Fixed and rebased, thanks for the feedback!

@alexcrichton
Copy link
Member

@bors: r+ 2305dc0

@bors
Copy link
Contributor

bors commented Sep 14, 2015

⌛ Testing commit 2305dc0 with merge 523acd9...

bors added a commit that referenced this pull request Sep 14, 2015
@bors
Auto merge of #28368 - lfairy:write-impl, r=alexcrichton
523acd9 
There is already a corresponding impl for `std::io::Write`. This change
will make the two traits more consistent.
@bors
Copy link
Contributor

bors commented Sep 14, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 2305dc0 into rust-lang:master Sep 14, 2015
@lambda-fairy lambda-fairy deleted the write-impl branch September 14, 2015 07:50
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lambda-fairy @rust-highfive @alexcrichton @bors @nikomatsakis @bluss